Put AIP-44 internal API behind feature flag #30510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
bbovenzi,
kaxil and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:CLI
area:dev-tools
area:webserver
jedcunningham
approved these changes
Apr 6, 2023
potiuk
force-pushed
the
put-aip-44-behind-feature-flag
branch
2 times, most recently
from
bd1280d to
a97f0b7
Compare
This includes: * configurable setting with defaults taken from env variable * raising exception if config variables are used with feature flag not enabled * hiding config values (adding mechanism to hide config values that are set for the future versions) * skipping tests
potiuk
force-pushed
the
put-aip-44-behind-feature-flag
branch
from
a97f0b7 to
8b6753c
Compare
Member
Author
|
OK. Mine should be ready to - I also incorporated the flag from AIP-52 and added it to the "disable in-progress" job - so that we can make sure all the newly added tests for both AIPs are also hidden behind the flags, and we will be safe to cherry-pick changes to 2.6 branch. |
mhenc
approved these changes
Apr 7, 2023
Member
Author
|
Follow up (found a problem with part of internal api tests NOT being run in CI anyway no matter the flag :) #30518 |
ephraimbuddy
added
changelog:skip
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.