Optimize performance of scheduling mapped tasks#30372
Merged
potiuk merged 3 commits intoApr 22, 2023
Merged
Conversation
Contributor
Author
|
FYI @uranusjr |
uranusjr
reviewed
Apr 10, 2023
dzhigimont
force-pushed
the
optimize_performance_of_scheduling_mapped_tasks
branch
4 times, most recently
from
April 12, 2023 08:12
cd97686 to
06c2350
Compare
dzhigimont
force-pushed
the
optimize_performance_of_scheduling_mapped_tasks
branch
from
April 18, 2023 08:01
06c2350 to
cba4a08
Compare
Member
|
Ah. Sorry missed that one. Yes. it should be fine - same as heartrate, as long as it is Optional. We will figure out the right way of populating it when we get to completing AIP-44 implementation. |
Member
|
Closed /reopened to rebuild. There was a problem with GitHub being down during last hour and I think it affected the PR build jobs. |
potiuk
approved these changes
Apr 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The improvement contains two cases:
Calling _revise_map_indexes_if_mapped for each task instance was significantly slowing down the scheduling, but it's enough to call the method only once per task id. The improvement reduced the time for scheduling 10k mapped tasks in my case from 7 - 10 minutes to seconds.
Closes: expand dynamic mapped tasks in batches #29959.