Also limit importlib on Python 3.9 #30069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original apache#29924 fix containt both > and < condition on Python 3.9 thus the limit did not apply to Python 3.9
ephraimbuddy
approved these changes
Mar 13, 2023
kaxil
approved these changes
Mar 13, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 13, 2023
ephraimbuddy
added
type:bug-fix
64 tasks
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Mar 21, 2023
This reverts commit 6e2bdcf. The change was done hastily when we released rc1 of 2.5.1 but it turned out to be a red-herring and something that was not really caused by Airflow's dependencies. The importlib_metadata should still be only added as dependency for Python < 3.9 as Python 3.9 does not need it. Also installing importlib_metadata manually (or by other dependencies) even in 6.1 version does not result in automated triggering of the issue - if someone happens to install importlib_metadata in Python 3.9 simply uninstalling it should solve the problem.
potiuk
added a commit
that referenced
this pull request
Mar 21, 2023
This reverts commit 6e2bdcf. The change was done hastily when we released rc1 of 2.5.1 but it turned out to be a red-herring and something that was not really caused by Airflow's dependencies. The importlib_metadata should still be only added as dependency for Python < 3.9 as Python 3.9 does not need it. Also installing importlib_metadata manually (or by other dependencies) even in 6.1 version does not result in automated triggering of the issue - if someone happens to install importlib_metadata in Python 3.9 simply uninstalling it should solve the problem.
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 24, 2023
This reverts commit 6e2bdcf. The change was done hastily when we released rc1 of 2.5.1 but it turned out to be a red-herring and something that was not really caused by Airflow's dependencies. The importlib_metadata should still be only added as dependency for Python < 3.9 as Python 3.9 does not need it. Also installing importlib_metadata manually (or by other dependencies) even in 6.1 version does not result in automated triggering of the issue - if someone happens to install importlib_metadata in Python 3.9 simply uninstalling it should solve the problem. (cherry picked from commit 3ec47ec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original #29924 fix containt both > and < condition on Python 3.9 thus the limit did not apply to Python 3.9
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.