Skip to content

Disable ordering DagRuns search result by note#30043

Merged
potiuk merged 1 commit into
apache:mainfrom
hussein-awala:fix/disable_order_by_note
Mar 14, 2023
Merged

Disable ordering DagRuns search result by note#30043
potiuk merged 1 commit into
apache:mainfrom
hussein-awala:fix/disable_order_by_note

Conversation

@hussein-awala

Copy link
Copy Markdown
Member

closes: #30041
related: #27849


After moving the notes to a new table, we removed note from the supported search and sort columns for all the APIs, and it seems we forgot disabling this one.

@boring-cyborg boring-cyborg Bot added the area:webserver Webserver related Issues label Mar 11, 2023

@mayeulk mayeulk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.
Until a fix is found to re-enable this, I use direct connection in the PG backend, with:
SELECT *
FROM public.dag_run_note
ORDER BY content
;

@uranusjr

Copy link
Copy Markdown
Member

From a quick look, I think we need to override apply_order_by in the data model (our CustomSQLAInterface) to support this. That’s probably more work, and I’d argue ordering by note is not particularly essential anyway and can wait for interested contributors.

@potiuk
potiuk merged commit 12b88cc into apache:main Mar 14, 2023
@ephraimbuddy ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sorting by Note in List Dag Run fails

5 participants