Fix memory exhaution with new containerd #29848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
changed the title
potiuk
force-pushed
the
fix-infinite-nofiles-from-containerd
branch
from
6f11195 to
fde1eb3
Compare
Member
Author
|
Might be not needed - seems that a new version of python_daemon is coming with improved memory management in this case. See https://pagure.io/python-daemon/issue/72 |
potiuk
force-pushed
the
fix-infinite-nofiles-from-containerd
branch
2 times, most recently
from
c3990d1 to
c9eaf4f
Compare
potiuk
changed the title
This PR vendors-in 2.3.2 version of the `python-daemon` package in order to fix the apache#29841 issue resulting from containerd configure infinite nofile as default.
potiuk
force-pushed
the
fix-infinite-nofiles-from-containerd
branch
from
c9eaf4f to
28efc53
Compare
This PR synchronizes to the main version of python-daemon (e38f05a5780626637e7ff10a08f9ed354acbe399) as of 03.03.2023. This version has been tested and solves the problem where starting python-daemon inside newer containerd with unlimited nofile limits uses up the whole available memory. It is added on top of apache#29845 that vendors-in 2.3.2 version of the package. This one and apache#29845 should be removed and replaced with >= requirement of python-daemon once it is released. Fixes: apache#29841
potiuk
force-pushed
the
fix-infinite-nofiles-from-containerd
branch
from
28efc53 to
b45c4db
Compare
potiuk
changed the title
potiuk
changed the title
Member
Author
|
Closed in favour of #29916 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR synchronizes to the main version of python-daemon
(e38f05a5780626637e7ff10a08f9ed354acbe399) as of 03.03.2023.
This version has been tested and solves the problem where
starting python-daemon inside newer containerd with unlimited
nofile limits uses up the whole available memory.
It is added on top of #29845 that vendors-in 2.3.2 version of the package.
This one and #29845 should be removed and replaced with >= requirement
of python-daemon once it is released.
Fixes: #29841
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.