Fix and augment check-for-inclusive-language CI check
#29549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
josh-fell
force-pushed
the
inclusive-language-check
branch
4 times, most recently
from
112984e to
3a9ec1d
Compare
josh-fell
requested review from
ashb,
dstandish,
ephraimbuddy,
jedcunningham and
potiuk
as code owners
Taragolis
reviewed
Feb 18, 2023
potiuk
approved these changes
Feb 20, 2023
josh-fell
force-pushed
the
inclusive-language-check
branch
from
3a9ec1d to
da85a59
Compare
Taragolis
approved these changes
Feb 21, 2023
josh-fell
force-pushed
the
inclusive-language-check
branch
from
da85a59 to
3a5a873
Compare
Related: apache#15994 apache#23090 This PR addresses a few items related to inclusive language use and the CI check: - There are several occurrences of "dummy" throughout documentation; however the current CI check for preventing non-inclusive language doesn't inspect `docs/` files. Ideally, the docs also include inclusive language. - Even when removing `docs/` from the exclusion list, non-inclusive language was still escaping pygrep. Upon inspection, the `(?x)` inline modifier was missing from the regex (although intended in apache#23090). Adding this modifier revealed these "dummy" instances and others related non-inclusive occurrences which were previously uncaught. - The exclusion list seemed too broad in places. There are still instances in which directories are excluded as a whole, but the list now is more tailored to non-inclusive occurrences that are beyond the purview of Airflow, history, dev/test files, etc.
josh-fell
force-pushed
the
inclusive-language-check
branch
from
3a5a873 to
34a2caa
Compare
Contributor
Author
|
Force pushing to hopefully get passed the test_cli_internal_api_background test now that it's quarantined. Thanks @Taragolis! |
uranusjr
approved these changes
Feb 22, 2023
Member
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
I didn’t check the exclude list; otherwise looks good to me.
pierrejeambrun
added
the
changelog:skip
40 tasks
Member
|
Requires a bunch of CI/dev commits to avoid conflicts on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #15994 #23090
This PR addresses a few items related to inclusive language use and the CI check:
docs/files. Ideally, the docs also include inclusive language.docs/from the exclusion list, non-inclusive language was still escaping pygrep. Upon inspection, the(?x)inline modifier was missing from the regex (although intended in Use inclusive words in apache airflow project #23090). Adding this modifier revealed these "dummy" instances and others related non-inclusive occurrences which were previously uncaught.