Remove stderr redirection for get-workflow-info #29381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
Feb 6, 2023
potiuk
force-pushed
the
fix-console-output-for-workflow-info
branch
from
9f99953 to
6c8f12b
Compare
The apache#28514 change added capability of getting trace errors for the command by swapping redirection of stderr and stdout, but debug output for github_output file remoined in stderr. This was no problem in most cases as rich did not produce color codes for stderr redirection and github_output was able to parse it properly - and each line in the GITHHUB_OUTPUT was simply duplicated. However, when number of labels was big, rich split the message and it caused Invalid format message.
potiuk
force-pushed
the
fix-console-output-for-workflow-info
branch
from
6c8f12b to
f987a96
Compare
Member
Author
|
There is a different error - but the error is due to something that started to happen over the weekend wiith addding github remote. I am trying to see what it is in #29385 |
Member
Author
|
We can merge that one now. Looking at the |
pierrejeambrun
added
the
changelog:skip
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
The #28514 change added capability of getting trace errors for the command by swapping redirection of stderr and stdout, but debug output for github_output file remoined in stderr. This was no problem in most cases as rich did not produce color codes for stderr redirection and github_output was able to parse it properly - and each line in the GITHHUB_OUTPUT was simply duplicated. However, when number of labels was big, rich split the message and it caused Invalid format message. (cherry picked from commit 9f1f026)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
The #28514 change added capability of getting trace errors for the command by swapping redirection of stderr and stdout, but debug output for github_output file remoined in stderr. This was no problem in most cases as rich did not produce color codes for stderr redirection and github_output was able to parse it properly - and each line in the GITHHUB_OUTPUT was simply duplicated. However, when number of labels was big, rich split the message and it caused Invalid format message. (cherry picked from commit 9f1f026)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #28514 change added capability of getting trace errors for the command by swapping redirection of stderr and stdout, but debug output for github_output file remoined in stderr.
This was no problem in most cases as rich did not produce color codes for stderr redirection and github_output was able to parse it properly - and each line in the GITHHUB_OUTPUT was simply duplicated.
However, when number of labels was big, rich split the message and it caused Invalid format message.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.