add output format arg for cli.dags.trigger#29224
Merged
potiuk merged 5 commits intoFeb 19, 2023
Merged
Conversation
ephraimbuddy
left a comment
ephraimbuddy
left a comment
Contributor
There was a problem hiding this comment.
Please add tests for the changes
ephraimbuddy
approved these changes
Feb 1, 2023
Co-authored-by: Ephraim Anierobi <[email protected]>
eladkal
approved these changes
Feb 17, 2023
potiuk
approved these changes
Feb 19, 2023
yupbank
reviewed
Jul 12, 2023
| "conf": dag_run.conf, | ||
| "dag_id": dag_run.dag_id, | ||
| "dag_run_id": dag_run.run_id, | ||
| "data_interval_end": dag_run.data_interval_start, |
Contributor
There was a problem hiding this comment.
what's the rational behind the swapping of data_interval_end -> dag_run.data_interval_start and data_interval_start -> dag_run.data_interval_end here ?
Member
Author
There was a problem hiding this comment.
Clearly this is a bug, here is the fix: #32548
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #29178
Add output format argument for the command
dags.triggerto simplify parsing the createdDagRuninfo.