Skip to content

Validate Sphinx Inventory file header #28838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 1 commit into from
Jan 10, 2023
Merged

Validate Sphinx Inventory file header #28838

potiuk merged 1 commit into from
Jan 10, 2023

Conversation

@Taragolis
Copy link
Contributor

@Taragolis Taragolis commented Jan 10, 2023

follow-up: #28834

  1. Before save inventory file validate headers
  2. Stop processing if any error happen during fetching inventory, it could save additional 20-40 minute because without inventories most probably documentation build would fail.

@Taragolis Taragolis requested review from ashb, kaxil and potiuk January 10, 2023 19:20
@Taragolis Taragolis requested a review from mik-laj as a code owner January 10, 2023 19:20
@Taragolis Taragolis force-pushed the validate-sphinx-inventory branch from a49694c to 4ea01f5 Compare January 10, 2023 21:17
potiuk
potiuk reviewed Jan 10, 2023
View reviewed changes
docs/exts/docs_build/fetch_inventories.py
shutil.copyfileobj(response.raw, f)
print(f"Fetched inventory: {url}")
if response.url != url:
print(f"{package_name}: {url} redirected to {response.url}")
Copy link
Member

@potiuk potiuk Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

potiuk
potiuk approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love It ❤️

@potiuk potiuk merged commit 04306f1 into apache:main Jan 10, 2023
@Taragolis Taragolis deleted the validate-sphinx-inventory branch January 10, 2023 23:22
ephraimbuddy pushed a commit that referenced this pull request Jan 12, 2023
@Taragolis @ephraimbuddy
Validate Sphinx Inventory file header (#28838)
e234beb 
(cherry picked from commit 04306f1)
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 13, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.5.1 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb

@kaxil kaxil Awaiting requested review from kaxil

@mik-laj mik-laj Awaiting requested review from mik-laj

Assignees

No one assigned

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation

Projects

None yet

Milestone

Airflow 2.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Taragolis @potiuk @ephraimbuddy