Google have re-worked their docs site ane appear not publish objects.inv #28834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least not on any URL I could guess at.
Member
Author
|
Filed googleapis/google-cloud-python#10814 upstream |
Taragolis
approved these changes
Jan 10, 2023
Contributor
Taragolis
left a comment
Taragolis
left a comment
There was a problem hiding this comment.
I add locally additional simple validation for inventories (will create as follow up PR).
The only two inventory related to google provider exists:
google-api-core: https://googleapis.dev/python/google-api-core/latest/objects.invgoogle-cloud-translate: https://googleapis.dev/python/translation/latest/objects.inv
I'm not sure should we keep them or not
#################### Fetching inventories ####################
To download 116 inventorie(s)
google-cloud-bigquery-datatransfer: Unexpected inventory header: <!doctype html>
google-cloud-automl: Unexpected inventory header: <!doctype html>
google-cloud-bigquery: Unexpected inventory header: <!doctype html>
google-cloud-bigtable: Unexpected inventory header: <!doctype html>
google-cloud-container: Unexpected inventory header: <!doctype html>
google-cloud-core: Unexpected inventory header: <!doctype html>
google-cloud-bigquery-storage: Unexpected inventory header: <!doctype html>
google-cloud-monitoring: Unexpected inventory header: <!doctype html>
google-cloud-datacatalog: Unexpected inventory header: <!doctype html>
google-cloud-kms: Unexpected inventory header: <!doctype html>
google-cloud-dlp: Unexpected inventory header: <!doctype html>
google-cloud-spanner: Unexpected inventory header: <!doctype html>
google-cloud-datastore: Unexpected inventory header: <!doctype html>
google-cloud-pubsub: Unexpected inventory header: <!doctype html>
google-cloud-language: Unexpected inventory header: <!doctype html>
google-cloud-redis: Unexpected inventory header: <!doctype html>
google-cloud-speech: Unexpected inventory header: <!doctype html>
google-cloud-storage: Unexpected inventory header: <!doctype html>
google-cloud-tasks: Unexpected inventory header: <!doctype html>
google-cloud-texttospeech: Unexpected inventory header: <!doctype html>
google-cloud-vision: Unexpected inventory header: <!doctype html>
google-cloud-videointelligence: Unexpected inventory header: <!doctype html>
Result: 94 success, 22 failed
Failed packages:
1. google-cloud-automl
2. google-cloud-bigquery
3. google-cloud-bigquery-datatransfer
4. google-cloud-bigquery-storage
5. google-cloud-bigtable
6. google-cloud-container
7. google-cloud-core
8. google-cloud-datacatalog
9. google-cloud-datastore
10. google-cloud-dlp
11. google-cloud-kms
12. google-cloud-language
13. google-cloud-monitoring
14. google-cloud-pubsub
15. google-cloud-redis
16. google-cloud-spanner
17. google-cloud-speech
18. google-cloud-storage
19. google-cloud-tasks
20. google-cloud-texttospeech
21. google-cloud-videointelligence
22. google-cloud-vision
Member
Author
|
Google are working on fixing this so we likely don't have to merge this PR |
Member
|
It's almost fixed while we wait for Google - but we need to add spellcheck exclusions: |
potiuk
approved these changes
Jan 10, 2023
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Pending spellcheck adding. I think it will take a while for Google to bring the inventories back (even if they treat it as p1)
Member
I'd merge it anyway - we never know how long it will take them and whether it will be working at first try |
Member
|
We can always simply revert it |
Member
|
Merge it - it was green. |
ephraimbuddy
added
the
changelog:skip
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Feb 14, 2023
…objects.inv (apache#28834)" This reverts commit 44d93be. Google re-published the .inv files after deleting them in January. Details in googleapis/google-cloud-python#10814
potiuk
added a commit
that referenced
this pull request
Feb 14, 2023
…objects.inv (#28834)" (#29543) This reverts commit 44d93be. Google re-published the .inv files after deleting them in January. Details in googleapis/google-cloud-python#10814
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
…objects.inv (#28834)" (#29543) This reverts commit 44d93be. Google re-published the .inv files after deleting them in January. Details in googleapis/google-cloud-python#10814 (cherry picked from commit c2c27c3)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
…objects.inv (#28834)" (#29543) This reverts commit 44d93be. Google re-published the .inv files after deleting them in January. Details in googleapis/google-cloud-python#10814 (cherry picked from commit c2c27c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least not on any URL I could guess at.
Removing this should un-break main.