Use dagrun instead of DagFileProcessor in backfill_job test #28724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
uranusjr
reviewed
Jan 5, 2023
tests/jobs/test_backfill_job.py
Outdated
Member
There was a problem hiding this comment.
Instead of relying on get_last_dagrun() (which can have bugs), it could be better to use SQLAlchemy directly here. There is a session pytest fixture you can use for this.
Member
|
Also, could you do some history digging ( |
Contributor
Author
#8015 PR was related |
9 tasks
uranusjr
reviewed
Jan 6, 2023
Member
|
Static checks need fixing/rebase is needed. |
Soonmok
requested review from
XD-DENG,
ashb,
bbovenzi,
dstandish,
eladkal,
ephraimbuddy,
jedcunningham,
jhtimmins,
josh-fell,
kaxil,
mik-laj,
o-nikolas,
potiuk and
ryanahamilton
as code owners
Soonmok
force-pushed
the
feature/ISSUE-23539
branch
from
247a55c to
a599a9d
Compare
uranusjr
reviewed
Jan 18, 2023
uranusjr
approved these changes
Jan 18, 2023
Member
|
Needs rebase/fixing static checks, |
potiuk
approved these changes
Jan 18, 2023
Taragolis
force-pushed
the
feature/ISSUE-23539
branch
from
0a1147c to
fbd09d7
Compare
Taragolis
added
changelog:skip
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #23539
Fix xfail test in
tests/jobs/test_backfill_job.py::test_trigger_controller_dagtest