Skip to content

Add guide for Apache Pinot operators #28653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eladkal merged 2 commits into from
Jan 12, 2023
Merged

Add guide for Apache Pinot operators #28653

eladkal merged 2 commits into from
Jan 12, 2023

Conversation

@shahar1
Copy link
Contributor

@shahar1 shahar1 commented Dec 30, 2022 •
edited by uranusjr
Loading

closes: #8194
related: #18930

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@shahar1 shahar1 requested a review from mik-laj as a code owner December 30, 2022 19:24
chethanuk
chethanuk reviewed Dec 30, 2022
View reviewed changes
@shahar1 shahar1 force-pushed the add-guide-for-apache-pinot-operators branch from 036b40c to 3d8ce11 Compare December 30, 2022 19:43
eladkal
eladkal reviewed Dec 30, 2022
View reviewed changes
@shahar1 shahar1 force-pushed the add-guide-for-apache-pinot-operators branch 3 times, most recently from 768b43f to 238708d Compare December 30, 2022 22:53
@shahar1 shahar1 requested review from eladkal and removed request for mik-laj December 30, 2022 22:53
josh-fell
josh-fell reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small suggestions. I agree with @eladkal that some context around the use of the pinot-admin.sh file in the task would be helpful.

@shahar1 shahar1 force-pushed the add-guide-for-apache-pinot-operators branch from 238708d to a3b73a6 Compare January 7, 2023 13:30
@shahar1
Copy link
Contributor Author

shahar1 commented Jan 7, 2023

Just a few small suggestions. I agree with @eladkal that some context around the use of the pinot-admin.sh file in the task would be helpful.

Thank you for all the suggestions, I committed them all.
Working on the final touches for documenting pinot-admin.sh and I think that we're ready do go :)

@shahar1 shahar1 force-pushed the add-guide-for-apache-pinot-operators branch 2 times, most recently from b515dba to d9645e2 Compare January 7, 2023 16:56
@eladkal
Copy link
Contributor

eladkal commented Jan 7, 2023

static checks are failing :(
You can avoid it by enabling pre-commits

@josh-fell
Copy link
Contributor

josh-fell commented Jan 9, 2023

static checks are failing :( You can avoid it by enabling pre-commits

@shahar1 Here is some info on the static code checks if you find it helpful.

@shahar1 shahar1 force-pushed the add-guide-for-apache-pinot-operators branch from d9645e2 to 54647a3 Compare January 9, 2023 16:37
@shahar1
Copy link
Contributor Author

shahar1 commented Jan 9, 2023

@eladkal @josh-fell Thank you!
I rebased upon the main branch and ran the static checks using Breeze, it should be ok now.

eladkal
eladkal approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@josh-fell any further comments?

josh-fell
josh-fell approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@josh-fell josh-fell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very small fix to a link, but otherwise LGTM! Long overdue. Thanks @shahar1 for tackling this!

@shahar1 shahar1 force-pushed the add-guide-for-apache-pinot-operators branch 2 times, most recently from afbc501 to a67d36b Compare January 9, 2023 21:37
@shahar1 shahar1 force-pushed the add-guide-for-apache-pinot-operators branch from b0bbee6 to 5572e4d Compare January 12, 2023 07:06
@eladkal eladkal merged commit 487b174 into apache:main Jan 12, 2023
@eladkal eladkal mentioned this pull request May 16, 2023
Closed
80 tasks
@shahar1 shahar1 deleted the add-guide-for-apache-pinot-operators branch June 12, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eladkal eladkal eladkal approved these changes

@josh-fell josh-fell josh-fell approved these changes

+1 more reviewer

@chethanuk chethanuk chethanuk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:providers kind:documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Guide for Apache Pinot operators

4 participants

@shahar1 @eladkal @josh-fell @chethanuk