Speed up provider validation pre-commit #28541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The provider validation pre-commit is now a lot slower after apache#28516 but it turned out that it has been also doing a little too much. It worked in the way (against the original design) that when any provider.yaml changed, validation was actually performed for all the providers, not only for those changed. This change improves the regular speed of running this validation when one or few providers are changed in the commit. It's not only limiting the validation to those provider.yaml files that changes but also performing subset of validations on those changed files if not all providers are changed or --all-files are not used (because some of the validations involving documentation and cross-provider dependencies require all provider.yaml files to be loaded and validated). The validation is still done in one "docker run" command though.
Member
Author
|
All green. |
uranusjr
reviewed
Dec 22, 2022
Member
Author
|
Anyone needs some speed-ups :) ? |
Taragolis
approved these changes
Dec 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provider validation pre-commit is now a lot slower after #28516 but it turned out that it has been also doing a little too much.
It worked in the way (against the original design) that when any provider.yaml changed, validation was actually performed for all the providers, not only for those changed.
This change improves the regular speed of running this validation when one or few providers are changed in the commit.
It's not only limiting the validation to those provider.yaml files that changes but also performing subset of validations on those changed files if not all providers are changed or --all-files are not used (because some of the validations involving documentation and cross-provider dependencies require all provider.yaml files to be loaded and validated).
The validation is still done in one "docker run" command though.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.