Skip to content

Remove deprecated AIPlatformConsoleLink from google/provider.yaml #28449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eladkal merged 1 commit into from
Dec 21, 2022
Merged

Remove deprecated AIPlatformConsoleLink from google/provider.yaml #28449

eladkal merged 1 commit into from
Dec 21, 2022

Conversation

@vchiapaikeo
Copy link
Contributor

@vchiapaikeo vchiapaikeo commented Dec 19, 2022

Exception is raised on webserver because a deprecated extra link was not removed from google/provider.yaml. This was removed as part of this PR: https://github.com/apache/airflow/pull/26836/files#diff-ee2dc8677bb15f1b09b5cf14d16fde2b48c0712cc3d4d2b08d478855634b4266L980

Webserver Logs:

10.253.8.251 - - [15/Dec/2022:18:32:58 +0000] "GET /object/next_run_datasets/recs_ranking_purchase_ranker_dag HTTP/1.1" 200 2 "https://web.airflow.etsy-syseng-gke-prod.etsycloud.com/dags/recs_ranking_purchase_ranker_dag/code" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36"
    raise ImportError(f'Module "{module_path}" does not define a "{class_name}" attribute/class')
  File "/home/airflow/.local/lib/python3.9/site-packages/airflow/utils/module_loading.py", line 38, in import_string
    imported_class = import_string(class_name)
  File "/home/airflow/.local/lib/python3.9/site-packages/airflow/providers_manager.py", line 275, in _sanity_check
Traceback (most recent call last):

During handling of the above exception, another exception occurred:

AttributeError: module 'airflow.providers.google.cloud.operators.mlengine' has no attribute 'AIPlatformConsoleLink'
    return getattr(module, class_name)
  File "/home/airflow/.local/lib/python3.9/site-packages/airflow/utils/module_loading.py", line 36, in import_string
Traceback (most recent call last):
[2022-12-15 18:32:58,068] {providers_manager.py:243} WARNING - Exception when importing 'airflow.providers.google.cloud.operators.mlengine.AIPlatformConsoleLink' from 'apache-airflow-providers-google' package
ImportError: Module "airflow.providers.google.cloud.operators.mlengine" does not define a "AIPlatformConsoleLink" attribute/class

Fixes: #28393

cc @uranusjr

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Dec 19, 2022
@vchiapaikeo vchiapaikeo mentioned this pull request Dec 19, 2022
Closed
2 tasks
@vchiapaikeo vchiapaikeo force-pushed the vchiapaikeo/fix-webserver-extra-links-v1 branch from e7bbada to fb4302e Compare December 19, 2022 01:40
@vchiapaikeo vchiapaikeo force-pushed the vchiapaikeo/fix-webserver-extra-links-v1 branch from fb4302e to 0eafe5c Compare December 19, 2022 13:13
@vchiapaikeo
Copy link
Contributor Author

vchiapaikeo commented Dec 19, 2022

Hi @turbaszek , can you please take a look when you have a moment?

@vchiapaikeo vchiapaikeo changed the title Remove deprecated AIPlatformConsoleLinkk from google/provider.yaml Remove deprecated AIPlatformConsoleLink from google/provider.yaml Dec 19, 2022
@vchiapaikeo vchiapaikeo force-pushed the vchiapaikeo/fix-webserver-extra-links-v1 branch from 0eafe5c to 3d10d13 Compare December 19, 2022 19:27
@eladkal eladkal mentioned this pull request Dec 20, 2022
Closed
1 task
eladkal
eladkal approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #28510 as a followup task to prevent this from happening again

@vchiapaikeo vchiapaikeo force-pushed the vchiapaikeo/fix-webserver-extra-links-v1 branch from 3d10d13 to 662db26 Compare December 20, 2022 22:54
@eladkal eladkal merged commit 7950fb9 into apache:main Dec 21, 2022
@eladkal eladkal mentioned this pull request Jan 2, 2023
Closed
84 tasks
ephraimbuddy pushed a commit that referenced this pull request Jan 12, 2023
@vchiapaikeo @ephraimbuddy
Remove deprecated AIPlatformConsoleLinkk from google/provider.yaml (#…
b7cf404 
…28449)

(cherry picked from commit 7950fb9)
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 13, 2023
@ephraimbuddy ephraimbuddy added this to the Airflow 2.5.1 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjr uranusjr uranusjr approved these changes

@eladkal eladkal eladkal approved these changes

@turbaszek turbaszek Awaiting requested review from turbaszek

Assignees

No one assigned

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:google Google (including GCP) related issues

Projects

None yet

Milestone

Airflow 2.5.1

Development

Successfully merging this pull request may close these issues.

Webserver reports "ImportError: Module "airflow.providers.google.cloud.operators.mlengine" does not define a "AIPlatformConsoleLink" attribute/class"

4 participants

@vchiapaikeo @uranusjr @eladkal @ephraimbuddy