Move Integration tests to separate package under tests #28170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:CLI
area:dev-tools
area:Scheduler
potiuk
force-pushed
the
move-integration-tests-to-integrtion-package
branch
2 times, most recently
from
f3e0103 to
c38d2dd
Compare
This is the first stage of improving the way how integration tests are run in our CI - first we want to separate them in a separate packages, and then we want to run them separately - one integration each in the CI.
potiuk
force-pushed
the
move-integration-tests-to-integrtion-package
branch
from
c38d2dd to
5c9570d
Compare
Member
Author
|
Looks cool. And Integration tests discovery is much faster now too. Maybe that alone will increase the stability of integration tests - because there is much lower number of Python test classes loaded during discovery for integration tests and maybe that will be enough to dcrease memory used during the tests. |
Taragolis
approved these changes
Dec 6, 2022
Contributor
Taragolis
left a comment
Taragolis
left a comment
There was a problem hiding this comment.
Looking good.
Found interesting message in the CI, which not based on any changes in this PR.
For some reason (or maybe I just can't fully understand logic of shell script) it shows that integrations disabled, but actually it run it 😮
Member
Author
Interesting :) |
Member
Author
I will fix it as part of splitting the integrations (and will remove some of the cryptic bash code serving it) |
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 13, 2023
This is the first stage of improving the way how integration tests are run in our CI - first we want to separate them in a separate packages, and then we want to run them separately - one integration each in the CI. (cherry picked from commit df608fe)
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 14, 2023
This is the first stage of improving the way how integration tests are run in our CI - first we want to separate them in a separate packages, and then we want to run them separately - one integration each in the CI. (cherry picked from commit df608fe)
84 tasks
86 tasks
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 7, 2023
When Pytest run tests it provides a summary of the tests. We are running a lot of the tests so we are really interested only in cases that are "interesting". So far we were not showing "skipped" tests in the summary, because there were cases where a lot of tests were skipped (mostly when integration tests were run - we collected tests from "tests" folder and run only those tests that were not skipped by @integration mark. This however changed in apache#28170 as we moved all integration tests to "integration" subfolder and now instead of large number of skipped tests we run them selectively for each integration. This should help in verifying that the skipped tests were skipped for a good reason (and that we actually see which tests have been skipped).
potiuk
added a commit
that referenced
this pull request
Apr 7, 2023
When Pytest run tests it provides a summary of the tests. We are running a lot of the tests so we are really interested only in cases that are "interesting". So far we were not showing "skipped" tests in the summary, because there were cases where a lot of tests were skipped (mostly when integration tests were run - we collected tests from "tests" folder and run only those tests that were not skipped by @integration mark. This however changed in #28170 as we moved all integration tests to "integration" subfolder and now instead of large number of skipped tests we run them selectively for each integration. This should help in verifying that the skipped tests were skipped for a good reason (and that we actually see which tests have been skipped).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first stage of improving the way how integration tests are run in our CI - first we want to separate them in a separate packages, and then we want to run them separately - one integration each in the CI.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.