Fix wrapping of run() method result of exasol and snoflake DB hooks #27997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change apache#27912 fixed and unified behaviour of DBApiHooks across the board, but it missed two places where sql was mis-used and overridden in exasol and snowflake hooks. The check for "sql" type did not use the original sql parameter value but the one that was overridden later in the run method implementation. The fix is the same as applied in Databricks Hook and DBAPI generic run methods - using consistent typing and separate variable to convert the sql string into sql list. Related: astronomer/astro-sdk#1324
boring-cyborg
bot
added
area:providers
provider:snowflake
2 tasks
potiuk
commented
Nov 29, 2022
| if isinstance(sql, str): | ||
| if split_statements: | ||
| sql = self.split_sql_string(sql) | ||
| sql_list: Iterable[str] = self.split_sql_string(sql) |
Member
Author
There was a problem hiding this comment.
The root cause of the problem is line https://github.com/apache/airflow/pull/27997/files#diff-00b215634013629b320a263630bf6948ed33c2a8528754fc78d69484e1320845R191
thesql parameter changed it type - when it was passed as "string", it was always converted to list and that caused the return to be wrapped in list as well. So when sql was used in return_single_query_results, it was already a list and return_single_query_resuts is always false when you pass list of queries.
Member
Author
|
@kazanzhy @denimalpaca -> this was the problem I introduced when fixing common.sql for 1.3.1 . Still looking for what caused the #27978 and #27976. |
uranusjr
approved these changes
Nov 30, 2022
6 tasks
jrggggg
pushed a commit
to jrggggg/airflow
that referenced
this pull request
Dec 1, 2022
…pache#27997) The change apache#27912 fixed and unified behaviour of DBApiHooks across the board, but it missed two places where sql was mis-used and overridden in exasol and snowflake hooks. The check for "sql" type did not use the original sql parameter value but the one that was overridden later in the run method implementation. The fix is the same as applied in Databricks Hook and DBAPI generic run methods - using consistent typing and separate variable to convert the sql string into sql list. Related: astronomer/astro-sdk#1324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change #27912 fixed and unified behaviour of DBApiHooks across the board, but it missed two places where sql was mis-used and overridden in exasol and snowflake hooks.
The check for "sql" type did not use the original sql parameter value but the one that was overridden later in the run method implementation.
The fix is the same as applied in Databricks Hook and DBAPI generic run methods - using consistent typing and separate variable to convert the sql string into sql list.
Related: astronomer/astro-sdk#1324
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.