Skip to content

Replace unittests in providers-apache tests by pure pytest #27948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 1 commit into from
Nov 27, 2022
Merged

Replace unittests in providers-apache tests by pure pytest #27948

potiuk merged 1 commit into from
Nov 27, 2022

Conversation

@Taragolis
Copy link
Contributor

@Taragolis Taragolis commented Nov 27, 2022

Migrate all Apache providers tests to pytest.

All changes are more or less straightforward:

  • Get rid of unittests.TestCase class and TestCase.assert* methods
  • Replace decorator parameterized.expand by pytest.mark.parametrize. I
  • replace requests_mock.mock decorator by requests_mock fixture
  • Convert TestCase.subTest to parametrize tests
  • Convert classes setUp* and tearDown* to appropriate pytest methods

See additional findings in comments

Taragolis
Taragolis commented Nov 27, 2022
View reviewed changes
tests/providers/apache/drill/operators/test_drill.py Outdated
Comment on lines 32 to -36
Copy link
Contributor Author

@Taragolis Taragolis Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestDrillOperator has a bit strange decorator might be some typo or outdated stuff:

  • Backend drill not exists
  • Integration drill not exists but might be exists in the past

Copy link
Member

@potiuk potiuk Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I think drill has been missing in action :)

tests/providers/apache/hdfs/sensors/test_hdfs.py Outdated
Comment on lines +103 to +107
Copy link
Contributor Author

@Taragolis Taragolis Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part previously exists in tests case methods.
Is a good idea get rid of this logger entirely?

Copy link
Member

@potiuk potiuk Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. We can get rid of it as a follow-up

tests/providers/apache/hdfs/sensors/test_hdfs.py Outdated
Comment on lines +198 to +202
Copy link
Contributor Author

@Taragolis Taragolis Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as mention for TestHdfsSensorFolder

Copy link
Member

@potiuk potiuk Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This seems to be a left-over and we should get rid of it as a follow-up.

tests/providers/apache/hive/hooks/test_hive.py Outdated
Comment on lines -58 to -71
Copy link
Contributor Author

@Taragolis Taragolis Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class only use once in the same module and also have the same name as reusable test class from tests/providers/apache/hive/__init__.py which may confuse

Copy link
Member

@potiuk potiuk Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep.

@Taragolis Taragolis force-pushed the providers-test-pytests-apache branch from 2e6b09e to 7630d4d Compare November 27, 2022 21:35
@potiuk
Copy link
Member

potiuk commented Nov 27, 2022

Yeah. I really like the pytest conversions :)

@potiuk potiuk merged commit 3ea4739 into apache:main Nov 27, 2022
@Taragolis Taragolis deleted the providers-test-pytests-apache branch November 28, 2022 02:27
@Taragolis Taragolis added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Nov 30, 2022
ephraimbuddy pushed a commit that referenced this pull request Jan 13, 2023
@Taragolis @ephraimbuddy
Replace unittests in providers-apache tests by pure pytest (#27948)
0b6bdcc 
(cherry picked from commit 3ea4739)
ephraimbuddy pushed a commit that referenced this pull request Jan 14, 2023
@Taragolis @ephraimbuddy
Replace unittests in providers-apache tests by pure pytest (#27948)
dd14501 
(cherry picked from commit 3ea4739)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

Assignees

No one assigned

Labels

area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Taragolis @potiuk