Use unused SQLCheckOperator.parameters in SQLCheckOperator.execute.#27599
Merged
potiuk merged 7 commits intoapache:mainfrom Nov 14, 2022
wjmolina:patch-1
Merged
Use unused SQLCheckOperator.parameters in SQLCheckOperator.execute.#27599potiuk merged 7 commits intoapache:mainfrom wjmolina:patch-1
potiuk merged 7 commits intoapache:mainfrom
wjmolina:patch-1
Conversation
uranusjr
approved these changes
Nov 10, 2022
Member
|
Can we have a test for this please? |
uranusjr
requested changes
Nov 11, 2022
uranusjr
approved these changes
Nov 11, 2022
eladkal
approved these changes
Nov 14, 2022
eladkal
reviewed
Nov 14, 2022
eladkal
approved these changes
Nov 14, 2022
Contributor
eladkal
left a comment
eladkal
left a comment
There was a problem hiding this comment.
will merge when CI is green
potiuk
approved these changes
Nov 14, 2022
|
Awesome work, congrats on your first merged pull request! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
executeof the classSQLCheckOperatoris not using the propertyparameters.