Sagemaker hook: remove extra call at the end when waiting for completion#27551
Merged
potiuk merged 1 commit intoapache:mainfrom Nov 8, 2022
Merged
Sagemaker hook: remove extra call at the end when waiting for completion#27551potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
also took the opportunity to speedup tests relying on this method by waiting zero
boring-cyborg
bot
added
area:providers
provider:amazon
uranusjr
approved these changes
Nov 7, 2022
vandonr-amz
commented
Nov 7, 2022
| raise AirflowException(f"SageMaker job took more than {max_ingestion_time} seconds") | ||
|
|
||
| self.log.info("SageMaker Job completed") | ||
| response = describe_function(job_name) |
Contributor
Author
There was a problem hiding this comment.
there is basically no latency between the last call of the loop (l.682) and this one, and moreover the status reached is supposed to be a terminal state, so there is no need to repeat the call here.
Comment on lines
-678
to
+677
| while running: | ||
| while True: |
Contributor
Author
There was a problem hiding this comment.
had to do this change otherwise python would complain that the response variable might be uninitialized in the return clause.
potiuk
approved these changes
Nov 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also took the opportunity to speedup tests relying on this method by waiting zero