Skip to content

Comments

Rename hook bigquery function _bq_cast to bq_cast#27543

Merged
potiuk merged 4 commits intoapache:mainfrom
astronomer:deprecate_bq_cast
Nov 11, 2022
Merged

Rename hook bigquery function _bq_cast to bq_cast#27543
potiuk merged 4 commits intoapache:mainfrom
astronomer:deprecate_bq_cast

Conversation

@pankajastro
Copy link
Member

@pankajastro pankajastro commented Nov 7, 2022 •
edited
Loading

Recently, I have started using hook bigquery function _bq_cast but I'm afraid that this might get changed silently since it is a private function so I want to rename it to bq_cast

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Nov 7, 2022
@pankajastro pankajastro mentioned this pull request Nov 7, 2022
Merged
uranusjr
uranusjr reviewed Nov 7, 2022
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we decide to make this function public, I also wonder if it’d be a good idea to move the function to somewhere in utils instead.

@pankajastro
Copy link
Member Author

pankajastro commented Nov 8, 2022

If we decide to make this function public, I also wonder if it’d be a good idea to move the function to somewhere in utils instead.

I was not able to find the right place to add it to utils. shall I create utils/provider.py or utils/type_cast.py?

@uranusjr
Copy link
Member

uranusjr commented Nov 9, 2022

Maybe airflow.providers.google.cloud.utils.bigquery? There’s already a bigquery_get_data so maybe it might make sense in there too…? Not sure.

@pankajastro
Copy link
Member Author

pankajastro commented Nov 9, 2022

Maybe airflow.providers.google.cloud.utils.bigquery? There’s already a bigquery_get_data so maybe it might make sense in there too…? Not sure.

for this PR scope, I'll be in favour of keeping it in airflow.providers.google.cloud.utils.bigquery latter maybe we can also move bigquery_get_data in airflow.providers.google.cloud.utils.bigquery

@potiuk potiuk merged commit 3aed495 into apache:main Nov 11, 2022
@pankajastro pankajastro mentioned this pull request Nov 11, 2022
Merged
Adityamalik123 pushed a commit to Adityamalik123/airflow that referenced this pull request Nov 12, 2022
@pankajastro @Adityamalik123
Rename hook bigquery function _bq_cast to bq_cast (apache#27543)
066a351
@potiuk potiuk mentioned this pull request Nov 15, 2022
Closed
@pankajastro pankajastro deleted the deprecate_bq_cast branch November 17, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uranusjr uranusjr uranusjr left review comments

@potiuk potiuk potiuk approved these changes

@turbaszek turbaszek Awaiting requested review from turbaszek

Assignees

No one assigned

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pankajastro @uranusjr @potiuk