Fix clearing child dag mapped tasks from parent dag #27501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Nov 7, 2022
zhiyong-ong
force-pushed
the
fix-mapped-task-recursive-clearing
branch
from
a27e48a to
e13ca42
Compare
uranusjr
approved these changes
Nov 16, 2022
potiuk
approved these changes
Nov 16, 2022
Member
|
Static checks need fixing. |
uranusjr
changed the title
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where clearing a parent dag will not clear the child dag's mapped task.
The bug was due to
TaskInstanceKeyaccepting its attributes in the order (dag_id, task_id, run_id, try_number, map_index) while in_get_task_instances, thepk_tuplethat we pass intoTaskInstanceKeyto get theresultis (dag_id, task_id, run_id, map_index), missing out the try_number. SoTaskInstanceKeyassumes that the map_index value supplied is try_number and defaults the value of map_index to -1. This causes a bunch of problems downstream when we try and retrieve theTaskInstancefrom the table using the map_index as part of the filter.fixes: #27462