Look for extra__ instead of extra_ in get_field#27489
Merged
dstandish merged 1 commit intoapache:mainfrom Nov 3, 2022
Merged
Conversation
This reduces likelihood of false positive. It's not possible as currently used. But if someone were to add an extra field `extra_info` for example, that would cause trouble avoided by this change.
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
ephraimbuddy
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reduces likelihood of false positive. It's not possible as currently used. But if someone were to add an extra field
extra_infofor example, that would cause trouble avoided by this change.