SagemakerProcessingOperator stopped honoring existing_jobs_found
#27456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
o-nikolas
approved these changes
Nov 2, 2022
eladkal
previously requested changes
Nov 4, 2022
ferruzzi
force-pushed
the
ferruzzi/sagemaker-increment
branch
from
b8c1420 to
996fbd3
Compare
Contributor
Author
|
Added the method back with deprecation and rebased |
ferruzzi
force-pushed
the
ferruzzi/sagemaker-increment
branch
from
996fbd3 to
57c2c3e
Compare
Member
|
Docs failure @ferruzzi :( |
Contributor
Author
|
I think that should do it. I'll rebase again once the tests are passing. |
ferruzzi
force-pushed
the
ferruzzi/sagemaker-increment
branch
from
dd5cee5 to
89e3848
Compare
Contributor
Author
|
Tests all passing; rebased |
potiuk
approved these changes
Nov 11, 2022
Adityamalik123
pushed a commit
to Adityamalik123/airflow
that referenced
this pull request
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #21711
The increment-name functionality was broken by #19195
I added back the code which increments the job name if the user says to, and added in a check for ThrottleException with a (user-overrideable) max of 3 retries and a bit of backoff (2/4/8 seconds) with an eventual exception after that. Also added a few unit tests to catch future regressions.