Apply log formatter on every ouput line in SSHOperator#27442
Merged
uranusjr merged 4 commits intoapache:mainfrom Nov 8, 2022
dolfinus:main
Merged
Apply log formatter on every ouput line in SSHOperator#27442uranusjr merged 4 commits intoapache:mainfrom dolfinus:main
uranusjr merged 4 commits intoapache:mainfrom
dolfinus:main
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
o-nikolas
reviewed
Nov 2, 2022
Co-authored-by: Niko <[email protected]>
Co-authored-by: Niko <[email protected]>
uranusjr
reviewed
Nov 2, 2022
potiuk
approved these changes
Nov 7, 2022
o-nikolas
approved these changes
Nov 7, 2022
Member
|
Static checks detected an error. |
uranusjr
approved these changes
Nov 8, 2022
Contributor
Author
|
Fixed the linter error |
|
Awesome work, congrats on your first merged pull request! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a command running by SSHOperator returns multiline logs, they are logged into task log. But logging format is applied only to the first line.
For example, logs printed by command:
and how they are printed to task log in Airflow:
Indents are messed up, this is really hard to read.
Now SSHHook splits multiline logs, and logs every line separately:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.