Make GSheetsHook return an empty list when there are no values#27261
Merged
potiuk merged 4 commits intoapache:mainfrom Oct 26, 2022
Merged
Make GSheetsHook return an empty list when there are no values#27261potiuk merged 4 commits intoapache:mainfrom
potiuk merged 4 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:providers
provider:google
eladkal
reviewed
Oct 25, 2022
| ) | ||
|
|
||
| return response["values"] | ||
| return response.get('values', []) |
Contributor
There was a problem hiding this comment.
Why empty list rather than None?
Contributor
Author
There was a problem hiding this comment.
Used an empty list to respect the function's signature, but None could also be valid if we're willing to change the return type to Optional[list].
Contributor
There was a problem hiding this comment.
To me it makes more sense to return what the API returns. If the API returns nothing so should we.
eladkal
approved these changes
Oct 25, 2022
potiuk
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GSheetsHook.get_values()now returns an empty list when there are no values in the spreadsheet range.Previously a
KeyErrorwas raised, which is not very ergonomic.