Drop support for providing resource as dict in KubernetesPodOperator#27197
Drop support for providing resource as dict in KubernetesPodOperator#27197eladkal merged 3 commits intoapache:mainfrom
resource as dict in KubernetesPodOperator#27197Conversation
boring-cyborg
bot
added
provider:cncf-kubernetes
eladkal
force-pushed
the
k8s
branch
2 times, most recently
from
85d1a4a to
43c66b0
Compare
dstandish
left a comment
dstandish
left a comment
There was a problem hiding this comment.
left comment but approving anyway
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Cool. Test needs fixing though.
eladkal
force-pushed
the
k8s
branch
3 times, most recently
from
6429678 to
1251b58
Compare
|
Ran the test locally on this branch (using virtualenv + docker desktop) Saw this is the error diff: |
There was a problem hiding this comment.
should we also remove this module?
There was a problem hiding this comment.
I didn't find any more usage in the code to convert_resources so I removed it.
I think we should remove the whole backward compact module but it needs more close look on the other functions
|
ok so to fix.... first of all, actual vs expected needs to be flipped in those asserts then this needs to be removed from the "expeced" (really just remove that line should do it, can leave the assert flipping for another time since it's tough for you to test locally) |
|
CI is green :) |
3 participants
Dropping support for resource parameter
Deprecation added in #24673
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.