-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Move min airflow version to 2.3.0 for all providers #27196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ca88184 to
a6bbef7
Compare
|
We need also update |
Right. Updated. |
a6bbef7 to
ee677fe
Compare
|
I'd love @uranusjr if you take a look as well. The biggest part of pre-2.3 was removal of dttm from "XCom.get_value" - mostly in operator links. Also I am not sure if what I've done is correct. I assumed that after migration to 2.3 each task instance will have a "task_instance_key" and we will be able to use task instance key and I would love your comments here @uranusjr if I understood correctly that we should genereally skip all the dttm usage and rely on task_instance_key being always present. I have found however one case where it is not as straightforward and dttm is still used and I am not sure if we want to do anything about it: In all the other cases I converted 'get_link" to |
f338a0e to
7c215d9
Compare
|
We also have: airflow/airflow/providers/oracle/hooks/oracle.py Lines 428 to 441 in b254a9f
|
f85ba70 to
c803412
Compare
Ah cool. Indeed. |
|
Actually, the DBApi one we could do before already after we split-out common.sql. |
c803412 to
04af807
Compare
|
Fixed. |
|
(also done the same for Trino, Snowflake and Databricks) |
04af807 to
7c8c056
Compare
|
Ahh we can also handle:
|
7c8c056 to
85cad69
Compare
9be69d7 to
32b060f
Compare
12c23d8 to
f57947a
Compare
|
This one also should cut the "compatibility" test by more than hour. Currently just installing latest providers on airflow 2.2 takes > 1 hour because |
dd5d587 to
527c5d1
Compare
|
All right - seems I get it alll green - @uranusjr - is it possible you take a look at the XCom.get_value() changes before I merge this one? |
|
Just did, I think you did it correctly. |
527c5d1 to
8ac8e56
Compare
Indeed. Thanks @eladkal for all the extra checks :) |
8ac8e56 to
e8a003b
Compare
As of October 11 our providers are supposed to be compatible with Airflow 2.3+ and all code for backwards compatibility with Airflow 2.2 can be removed now.
e8a003b to
d9aa251
Compare
As of October 11 our providers are supposed to be compatible with Airflow 2.3+ and all code for backwards compatibility with Airflow 2.2 can be removed now.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.