Skip to content

Comments

SSHOperator ignores cmd_timeout (#27182)#27184

Merged
potiuk merged 5 commits intoapache:mainfrom
punx120:27182
Nov 7, 2022
Merged

SSHOperator ignores cmd_timeout (#27182)#27184
potiuk merged 5 commits intoapache:mainfrom
punx120:27182

Conversation

@punx120
Copy link
Contributor

@punx120 punx120 commented Oct 21, 2022

closes: #27182


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 21, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@punx120 punx120 force-pushed the 27182 branch 2 times, most recently from ebef9ec to 0dc3bea Compare October 27, 2022 00:41
@eladkal
Copy link
Contributor

eladkal commented Oct 31, 2022

I think we can just remove timeout parameter.

if self.timeout:
warnings.warn(
"Parameter `timeout` is deprecated."
"Please use `conn_timeout` and `cmd_timeout` instead."
"The old option `timeout` will be removed in a future version.",
DeprecationWarning,
stacklevel=2,
)

The parameter is deprecated. Next release is a breaking change one so isn't it better to remove this parameter and adjust the fix accordingly?

@punx120
Copy link
Contributor Author

punx120 commented Oct 31, 2022

I think we can just remove timeout parameter.

if self.timeout:
warnings.warn(
"Parameter `timeout` is deprecated."
"Please use `conn_timeout` and `cmd_timeout` instead."
"The old option `timeout` will be removed in a future version.",
DeprecationWarning,
stacklevel=2,
)

The parameter is deprecated. Next release is a breaking change one so isn't it better to remove this parameter and adjust the fix accordingly?

Sure i can look into that

@punx120
Copy link
Contributor Author

punx120 commented Oct 31, 2022

I think we can just remove timeout parameter.

if self.timeout:
warnings.warn(
"Parameter `timeout` is deprecated."
"Please use `conn_timeout` and `cmd_timeout` instead."
"The old option `timeout` will be removed in a future version.",
DeprecationWarning,
stacklevel=2,
)

The parameter is deprecated. Next release is a breaking change one so isn't it better to remove this parameter and adjust the fix accordingly?

Sure i can look into that

Done!

@punx120
Copy link
Contributor Author

punx120 commented Nov 4, 2022

@eladkal @potiuk Can one of you please approve so we can merge it?

@potiuk potiuk merged commit dc760b4 into apache:main Nov 7, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 7, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSHOperator ignores cmd_timeout

4 participants