SSHOperator ignores cmd_timeout (#27182)#27184
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
ebef9ec to
0dc3bea
Compare
|
I think we can just remove timeout parameter. airflow/airflow/providers/ssh/operators/ssh.py Lines 102 to 109 in 64174ce The parameter is deprecated. Next release is a breaking change one so isn't it better to remove this parameter and adjust the fix accordingly? |
Sure i can look into that |
Done! |
|
Awesome work, congrats on your first merged pull request! |
closes: #27182
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.