Make amazon provider tests compatible with latest moto#27177
Merged
pierrejeambrun merged 1 commit intoapache:mainfrom Oct 21, 2022
Merged
Make amazon provider tests compatible with latest moto#27177pierrejeambrun merged 1 commit intoapache:mainfrom
moto#27177pierrejeambrun merged 1 commit intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:providers
provider:amazon
uranusjr
approved these changes
Oct 21, 2022
vincbeck
approved these changes
Oct 21, 2022
Contributor
vincbeck
left a comment
vincbeck
left a comment
There was a problem hiding this comment.
It makes the code even cleaner. Like that
Member
There was a problem hiding this comment.
Nice !
I started to observe CI failure on one of my PR lately #26872 with ACCOUNT_ID and dynamo related stuff. I didn't have time to take a look, but hope this will fix that 🤞 (or maybe I just made a bad rebase 😂)
pierrejeambrun
approved these changes
Oct 21, 2022
This was referenced Oct 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix broken main and remove some depreciation warnings.
mock_dynamodb2decorator deprecated bymock_dynamodbin moto >= 3.1.0 and remove in moto >= 4moto.core.ACCOUNT_IDreplaced bymoto.core.DEFAULT_ACCOUNT_ID