Add info about JSON Connection format for AWS SSM Parameter Store Secrets Backend#27134
Conversation
boring-cyborg
bot
added
area:providers
area:secrets
kind:documentation
provider:amazon
There was a problem hiding this comment.
Is it me or the sentence In some cases, URI's you will need stored in AWS SSM Parameter Store may not be intuitive does not make a lot of sense ?
There was a problem hiding this comment.
Good point to change it. If it confuse you than it might confuse others.
From my side I've just change "Secrets Manager" to "AWS SSM Parameter Store" and split long line.
There was a problem hiding this comment.
Nice. I would make it even simpler.
In some cases, URIs stored in AWS SSM Parameter Store may not be intuitive,
There was a problem hiding this comment.
I thought that initial author tried to highlight that Airflow connection URI not a specific connection URI.
E.g. user expected that HTTP https://example.org/path would work however in Airflow we should use http://https%3A%2F%2Fexample.org%2Fpath
There is also a link to example how to generate URI exists in current doc: https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html#generating-connection-uri
Taragolis
force-pushed
the
ssm-secret-backend-allow-json
branch
from
a9ac812 to
096a8ea
Compare
docs/apache-airflow-providers-amazon/secrets-backends/aws-ssm-parameter-store.rst
Outdated
Show resolved
Hide resolved
Taragolis
force-pushed
the
ssm-secret-backend-allow-json
branch
from
096a8ea to
52b20f9
Compare
|
Any more comments here :) ? |
Taragolis
force-pushed
the
ssm-secret-backend-allow-json
branch
from
52b20f9 to
7e2cd9d
Compare
I've just add reuse same pytest parameters in different tests cases |
Taragolis
force-pushed
the
ssm-secret-backend-allow-json
branch
2 times, most recently
from
82da4bb to
d3d4c49
Compare
Taragolis
force-pushed
the
ssm-secret-backend-allow-json
branch
from
d3d4c49 to
d9379e8
Compare
…ore Secrets Backend (apache#27134)
4 participants
Since Airflow 2.3 Connection could be represented as JSON object which perfectly work without any changes in
SystemsManagerParameterStoreBackend.get_conn_valueSystemsManagerParameterStoreBackend.get_conn_uriso it return always URI even if it stored as JSON objects. I do not know but might be better just remove this method since it should not use internally in Airflow since 2.3 however it might use in some user code.