Make pod name optional in KubernetesPodOperator#27120
Merged
dstandish merged 3 commits intoapache:mainfrom Oct 21, 2022
Merged
Conversation
boring-cyborg
bot
added
provider:cncf-kubernetes
When not provided, let's just use the task name, right?
dstandish
force-pushed
the
name-optional-in-kpo
branch
from
42120f5 to
023c0bd
Compare
eladkal
reviewed
Oct 18, 2022
| Features | ||
| ~~~~~~~~ | ||
|
|
||
| Previously, ``namespace`` and ``name`` were required arguments for KubernetesPodOperator. Now, if ``name`` is not supplied, ``task_id`` will be used. And if ``namespace`` is not supplied, and the task is running in a cluster, then the task pod's namespace will be used. |
Contributor
There was a problem hiding this comment.
mmm was name mandatory for KPO? I think it was optional because it could have been defined in pod template
Contributor
Author
There was a problem hiding this comment.
true, i'll clean it up in the namespace one
Contributor
Author
There was a problem hiding this comment.
actually, had to fix something anyway so clarified here
eladkal
approved these changes
Oct 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When not provided, let's just use the task name, right? Previously, if you did not provide it, you had to have provided a pod template or pod spec.