Allow and prefer non-prefixed extra fields for AzureFileShareHook#27041
Merged
dstandish merged 2 commits intoapache:mainfrom Oct 28, 2022
Merged
Allow and prefer non-prefixed extra fields for AzureFileShareHook#27041dstandish merged 2 commits intoapache:mainfrom
dstandish merged 2 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:providers
kind:documentation
provider:microsoft-azure
ferruzzi
approved these changes
Oct 20, 2022
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Left a non-blocking question/suggestion, otherwise LGTM.
Contributor
There was a problem hiding this comment.
Not sure what eff_key is here, maybe that's a known term I'm just not familiar with, but it looks like it's the short (non-prefixed) key name, so maybe just call it that?
dstandish
changed the title
dstandish
force-pushed
the
azure-fileshare-no-prefix
branch
from
05b96fc to
0190c60
Compare
From 2.3, non-prefixed extras are fully supported so we make this the preferred way.
dstandish
force-pushed
the
azure-fileshare-no-prefix
branch
from
0190c60 to
9b2cf94
Compare
potiuk
approved these changes
Oct 28, 2022
eladkal
approved these changes
Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From 2.3, non-prefixed extras are fully supported so we make this the preferred way.