Remove extra__kubernetes__ prefix from k8s hook extras#27021
Merged
dstandish merged 2 commits intoapache:mainfrom Oct 22, 2022
Merged
Remove extra__kubernetes__ prefix from k8s hook extras#27021dstandish merged 2 commits intoapache:mainfrom
dstandish merged 2 commits intoapache:mainfrom
Conversation
We still support connections defined the old way; but we no longer need to use this prefix.
boring-cyborg
bot
added
provider:cncf-kubernetes
| we needed to store them with the prefix ``extra__kubernetes__``. This method | ||
| handles the backcompat, i.e. if the extra dict contains prefixed fields. | ||
| """ | ||
| if field_name.startswith('extra_'): |
Contributor
There was a problem hiding this comment.
Can we check for the exact string extra__?
eladkal
approved these changes
Oct 21, 2022
dstandish
commented
Oct 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still support connections defined the old way; but we no longer need to use this prefix.