Skip to content

Comments

Fix log message for kubernetes hooks#26999

Merged
uranusjr merged 3 commits intoapache:mainfrom
FingerLiu:main
Oct 28, 2022
Merged

Fix log message for kubernetes hooks#26999
uranusjr merged 3 commits intoapache:mainfrom
FingerLiu:main

Conversation

@FingerLiu
Copy link
Contributor

@FingerLiu FingerLiu commented Oct 12, 2022

Some log in kubernetes hook show "SparkApplication", but the hook works for all kinds of kubernetes CRD.
This PR fix log message to avoid miss leading.

@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes (k8s) provider related issues area:providers labels Oct 12, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 12, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@FingerLiu
Copy link
Contributor Author

hi @jedcunningham plz take a look here

@potiuk
Copy link
Member

potiuk commented Oct 25, 2022

Resolved the "normalization" conflict and re-run it. Let's see.

@uranusjr uranusjr merged commit 4797a03 into apache:main Oct 28, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 28, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants