Conversation
boring-cyborg
bot
added
area:providers
provider:amazon
Contributor
|
Can you please update description with full details of the issue? |
Contributor
Author
|
Sorry for the delay, I was away on holiday. Updated. |
ECSTaskFlowFetcher incorrectly displayed a deprecation notice when used correctly. coauthor: Taragolis
ferruzzi
force-pushed
the
ferruzzi/ecs-operator-fix
branch
from
7e054b1 to
d2f8832
Compare
Contributor
Author
|
Failing test is unrelated to my change. |
uranusjr
approved these changes
Oct 19, 2022
Contributor
Failing test was fixed in #27115 |
Contributor
Author
Thanks, I figured it was something in main, I was going to check it and rebase again this morning but looks like you got it for me. Cheers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EcsTaskLogFetcher incorrectly displayed a deprecation notice when used correctly.
Fixes: https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1664397142464329
Details: EcsTaskLogFetcher was moved from the operator module to the hook module a while back.
_get_task_log_fetcherwas still using the (old, deprecated) wrapper method which showed the deprecation notice each time even if the user wasn't calling the deprecated class themselves.coauthor: Taragolis