Fix a bunch of deprecation warnings AWS tests#26857
Merged
uranusjr merged 7 commits intoapache:mainfrom Oct 6, 2022
Merged
Conversation
boring-cyborg
bot
added
area:logging
area:providers
area:secrets
provider:amazon
We are already on watchtower>=2.0 so the new arguments should always be available.
uranusjr
force-pushed
the
warnings-clean
branch
from
55f2ca0 to
8c13cb8
Compare
eladkal
approved these changes
Oct 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TBH I originally set of to fix all warnings originate from the provider code base (i.e. exlucding those from Moto etc.) but eventually just got bored after this one provider.
Note to reviewers: It may be easier to read each commit in this PR individually (each of them fix one particular deprecation warning) instead of reading the diff in its entirety (which would have all kinds of changes intertwined).