Skip to content

Comments

Don't consider airflow core conf for KPO#26849

Merged
dstandish merged 3 commits intoapache:mainfrom
astronomer:remove-kpo-consideration-core-params
Oct 4, 2022
Merged

Don't consider airflow core conf for KPO#26849
dstandish merged 3 commits intoapache:mainfrom
astronomer:remove-kpo-consideration-core-params

Conversation

@dstandish
Copy link
Contributor

@dstandish dstandish commented Oct 3, 2022

Note: this should not be released until provider version 5.0

This was deprecated in provider version 4.1.0, and now we are removing the backcompat logic, so that core conf params will no longer be considered when creating the k8s client object; users will need to use Airflow connections if they want the client configured in a non-default way.

@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes (k8s) provider related issues area:providers labels Oct 3, 2022
@uranusjr
Copy link
Member

uranusjr commented Oct 4, 2022

Test is failing

@dstandish dstandish force-pushed the remove-kpo-consideration-core-params branch from a87ddfe to 67ad563 Compare October 4, 2022 03:40
This was deprecated in provider version 4.1.0, and now we are removing the backcompat logic, so that core conf params will no longer be considered when creating the k8s client object; users will need to use Airflow connections if they want the client configured in a non-default way.
@dstandish dstandish force-pushed the remove-kpo-consideration-core-params branch from 67ad563 to bfda3a3 Compare October 4, 2022 17:25
@dstandish dstandish merged commit 53d6804 into apache:main Oct 4, 2022
@dstandish dstandish deleted the remove-kpo-consideration-core-params branch October 4, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants