Fix separator getting added to variables_prefix when empty#26749
Merged
potiuk merged 3 commits intoapache:mainfrom Sep 30, 2022
Merged
Fix separator getting added to variables_prefix when empty#26749potiuk merged 3 commits intoapache:mainfrom
potiuk merged 3 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:providers
area:secrets
provider:microsoft-azure
rajaths010494
changed the title
o-nikolas
requested changes
Sep 28, 2022
rajaths010494
force-pushed
the
fix_azure_variables_prefix
branch
from
291350b to
4cf0d04
Compare
uranusjr
approved these changes
Sep 29, 2022
Contributor
Author
|
tests/providers/google/cloud/utils/test_credentials_provider.py::TestGetGcpCredentialsAndProjectId::test_disable_logging: Failed: DID NOT RAISE <class 'AssertionError'> is failing but i haven't changed anything in Google cloud. |
rajaths010494
force-pushed
the
fix_azure_variables_prefix
branch
from
4cf0d04 to
a44f4fa
Compare
o-nikolas
approved these changes
Sep 29, 2022
azure key vault adds a - between the key prefix and the secret name when it reads it from azure key vault. It does this even when the key prefix is "" so secrets end up named -my-secret instead of my-secret.
Co-authored-by: Niko <[email protected]>
rajaths010494
force-pushed
the
fix_azure_variables_prefix
branch
from
a44f4fa to
55cf79e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the bug
azure key vault adds a - between the key prefix and the secret name when it reads it from the azure key vault. It does this even when the variables prefix is "" so secrets end up named -my-secret instead of my-secret.
To Reproduce
Follow the instructions to set up an azure key vault integrated install with a variables_prefix of "".
Create a secret named -my-var in the azure key vault.
Use the example dag provided in the docs with Variable.get("my-var")
You will see that it fetches the variable because it is incorrectly mapping my-var to -my-var instead of my-var.
Expected Behaviour
connections_prefix and variables_prefix don't add a leading - when they are set to "".
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.