Do not restart breeze containers after restart #26647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid initialisation of database and other integrations when you are entering/leaving breeze, those are started when breeze starts but not stopped when you leave. Then stopping such running auxiliary containers should be done with `breeze stop` after you are done. However those who do not do it, and will restart their machine will find that the containers get restarted. This has been added as part of apache#13446 where health-checks are added. However "always" was not a good choice. It should have been "on-failure"
Member
Author
|
@mik-laj -> as @dstandish noticed in https://apache-airflow.slack.com/archives/CCPRP7943/p1663959432825839 - we have containers restarting on rebooting the machine/docker after adding the health check (so if you have not run |
mik-laj
approved these changes
Sep 24, 2022
pierrejeambrun
approved these changes
Sep 24, 2022
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
In order to avoid initialisation of database and other integrations when you are entering/leaving breeze, those are started when breeze starts but not stopped when you leave. Then stopping such running auxiliary containers should be done with `breeze stop` after you are done. However those who do not do it, and will restart their machine will find that the containers get restarted. This has been added as part of #13446 where health-checks are added. However "always" was not a good choice. It should have been "on-failure" (cherry picked from commit 337146d)
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 10, 2022
In order to avoid initialisation of database and other integrations when you are entering/leaving breeze, those are started when breeze starts but not stopped when you leave. Then stopping such running auxiliary containers should be done with `breeze stop` after you are done. However those who do not do it, and will restart their machine will find that the containers get restarted. This has been added as part of #13446 where health-checks are added. However "always" was not a good choice. It should have been "on-failure" (cherry picked from commit 337146d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid initialisation of database and other integrations when you are entering/leaving breeze, those are started when breeze starts but not stopped when you leave. Then stopping such running auxiliary containers should be done with
breeze stopafter you are done. However those who do not do it, and will restart their machine will find that the containers get restarted.This has been added as part of #13446 where health-checks are added. However "always" was not a good choice. It should have been "on-failure"
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.