Rename schema to database in PostgresHook#26436
Merged
kaxil merged 9 commits intoapache:mainfrom Sep 27, 2022
Merged
Conversation
In PostgresHook the "schema" field is only being called like that to make it compatible with the underlying DbApiHook which uses the schema for the sql alchemy connector. The postgres connector library however does not allow setting a schema in the connection instead a database can be set. To clarify that, we change all references in the PostgresHook code and documentation.
feluelle
commented
Sep 16, 2022
docs/apache-airflow-providers-postgres/connections/postgres.rst
Outdated
Show resolved
Hide resolved
kaxil
reviewed
Sep 18, 2022
- use deprecation warning instead of log.error - clarify docs about database & schema
feluelle
commented
Sep 19, 2022
feluelle
commented
Sep 20, 2022
potiuk
reviewed
Sep 20, 2022
docs/apache-airflow-providers-postgres/connections/postgres.rst
Outdated
Show resolved
Hide resolved
potiuk
approved these changes
Sep 20, 2022
ashb
reviewed
Sep 23, 2022
kaxil
approved these changes
Sep 27, 2022
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Sep 27, 2022
This reverts commit 642375f.
89 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PostgresHook the "schema" field is only being called like that to make it compatible with the underlying DbApiHook which uses the schema for the sql alchemy connector. The postgres connector library however does not allow setting a schema in the connection instead a database can be set. To clarify that, we change all references in the PostgresHook code and documentation.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.