Fix SystemsManagerParameterStoreBackend test #25751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been failing since the backend moved use_ssl to a separated attribute instead of bundling it in kwargs.
eladkal
approved these changes
Aug 17, 2022
uranusjr
deleted the
fix-failing-systems-manager-parameter-store-backend-test
branch
Member
|
I looked at why it was not caught in the PR. The problem is that the system manager tests are not run when only providers change. I we should move them to "always" part to catch similar kind of problems. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 17, 2022
The secrets tests are interacting with providers so changes in providers secrets implementation might break those tests. Moving them to "always" folder prevents them from accepting a PR that breaks other PRs. Related: apache#25751 apache#25628
Member
|
Fix preventing it from happening in the future in #25760 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been failing since b9b8841, which moved
use_sslto a separated attribute instead of bundling it inkwargs.@Taragolis