Allow AWS Secrets Backends use AWS Connection capabilities #25628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:secrets
kind:documentation
provider:amazon
Taragolis
force-pushed
the
amazon-secrets-backends-connection
branch
2 times, most recently
from
626797f to
461f5ab
Compare
o-nikolas
reviewed
Aug 10, 2022
Contributor
o-nikolas
left a comment
o-nikolas
left a comment
There was a problem hiding this comment.
These code modules are a little obtuse (not your fault) so it's difficult to review with high confidence, but I've had a look and left some comments
2 tasks
Taragolis
force-pushed
the
amazon-secrets-backends-connection
branch
from
461f5ab to
3d42954
Compare
Taragolis
force-pushed
the
amazon-secrets-backends-connection
branch
from
83d3ca2 to
b5060c0
Compare
Contributor
Author
I hope in near future we could also drop all deprecated configs, which makes it easier to maintain and expand. BTW, finally fix/change suggestion and pass tests |
potiuk
approved these changes
Aug 16, 2022
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 17, 2022
The secrets tests are interacting with providers so changes in providers secrets implementation might break those tests. Moving them to "always" folder prevents them from accepting a PR that breaks other PRs. Related: apache#25751 apache#25628
25 tasks
ephraimbuddy
added
the
changelog:skip
This was referenced Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In additional added new Extra Connection parameters
profile_name- this only one parameter which could be assigned tosession_kwargswithout any side effects in current provider, so I thought there is no reason usesession_kwargs.verify- this parameter could specified at that moment only in hook (right now), but not in connection.Update documentation and split Extra Connection Config by sections.
closes: #25326 (updated, initially mention wrong issue)