Fix PostgresToGCSOperat bool dtype #25475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When converting postgres boolean data type it was defaulting to the parquet parquet.string() data type. Pyarrow would then raise an error when attempting to convert the boolean data type into its string. Changing the PostgresToGCSOperator class map `data_type` to convert postgres boolean type to bigquery `BOOL` data type which then maps to the parquet `pa.bool_()` data type when `_convert_parquet_schema` is called.
boring-cyborg
bot
added
area:providers
provider:google
potiuk
approved these changes
Aug 2, 2022
|
Awesome work, congrats on your first merged pull request! |
This was referenced Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting postgres boolean data type it was defaulting to the
parquet parquet.string() data type. Pyarrow would then raise an error
when attempting to convert the boolean data type into its string.
Changing the PostgresToGCSOperator class map
data_typeto convertpostgres boolean type to bigquery
BOOLdata type which then maps tothe parquet
pa.bool_()data type when_convert_parquet_schemaiscalled.
closes: #25474