-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix BigQueryInsertJobOperator cancel_on_kill #25342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Jul 29, 2022
Member
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks cool
Member
|
Some errors though |
josh-fell
reviewed
Jul 29, 2022
Contributor
Author
Fixed the failed test case. The |
potiuk
approved these changes
Aug 4, 2022
|
Awesome work, congrats on your first merged pull request! |
This was referenced Aug 10, 2022
|
good work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with BigQueryInsertJobOperator. If the task reaches timeout set by task
execution_timeout,on_killwill be called but theself.job_idis None. This is because the function_submit_jobis a blocking call butself.job_idis only set after it. This PR is hugely inspired by #22955.