Fix too long names of files and docker compose projects #25301
Conversation
When there is a change spanning multiple providers, the test type might be very long "Providers[google,microsoft.mssql......]". Test type is used in generating directory/file names as well as in determining docker compose project names and such long name might be just ... too long. But at any point in time we only run one Provider* test type, so we can simply truncate the "[*]" when we use TEST_TYPE to determine dir and docker-compose name. This PR does exactly this.
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Rather than having to do the same replacement in 4 different places might it be cleaner to set that once in what ever is setting TEST_TYPE (and/or introduct a TEST_TYPE_SAFE/TEST_TYPE_CLEAN variable if there are more uses that want the existing full one)
I thought about it, but we would have to additionally pass this extra variable across multiple levels - from Host script (where we assign the name of docker compose project) to parallel execution script (which executes gnu paralllel) and finally to actual test execution script (the one that is executed by gnu-parallel). It is totally not worth it especialy that we are going to replace it with new python-based breeze parallelism (as we did with other parts already). This is something that is is in progress #23715 and I hope will be finished soon. |
|
No worries @Bowrna . There are plenty of small things that are distracting fron finish it but we will get there soon enough |
The apache#25301 fixed too long names for files in case of long list of providers but there is one more place it needs to be fixed - in the volume name of MsSQL tests.
The #25301 fixed too long names for files in case of long list of providers but there is one more place it needs to be fixed - in the volume name of MsSQL tests.
When there is a change spanning multiple providers, the test type might be very long "Providers[google,microsoft.mssql......]". Test type is used in generating directory/file names as well as in determining docker compose project names and such long name might be just ... too long. But at any point in time we only run one Provider* test type, so we can simply truncate the "[*]" when we use TEST_TYPE to determine dir and docker-compose name. This PR does exactly this. (cherry picked from commit a0aa93f)
ephraimbuddy
added
the
changelog:skip
4 participants
When there is a change spanning multiple providers, the test type
might be very long "Providers[google,microsoft.mssql......]".
Test type is used in generating directory/file names as well as
in determining docker compose project names and such long name might
be just ... too long. But at any point in time we only run one
Provider* test type, so we can simply truncate the "[*]" when we
use TEST_TYPE to determine dir and docker-compose name.
This PR does exactly this.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.