Skip to content

Convert RDS Export Sample DAG to System Test (AIP-47) #25205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 2 commits into from
Jul 21, 2022
Merged

Convert RDS Export Sample DAG to System Test (AIP-47) #25205

potiuk merged 2 commits into from
Jul 21, 2022

Conversation

@ferruzzi
Copy link
Contributor

@ferruzzi ferruzzi commented Jul 20, 2022

Follows the template set forward in #24643

  • Also fixes a mistake in the docstring for _await_status which incorrect described the method's behavior.
  • Also adds a "wait_for_completion" flag to the relevant operators as seen in many other operators to allow for easier unit testing of the operators and unit testing to test the flags to allow the testing to be tested.

@ferruzzi ferruzzi requested a review from mik-laj as a code owner July 20, 2022 21:49
chethanuk
chethanuk reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@chethanuk chethanuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@potiuk potiuk merged commit f6bda38 into apache:main Jul 21, 2022
@eladkal eladkal mentioned this pull request Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@mik-laj mik-laj Awaiting requested review from mik-laj

+1 more reviewer

@chethanuk chethanuk chethanuk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:providers area:system-tests kind:documentation provider:amazon AWS/Amazon - related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ferruzzi @potiuk @chethanuk