Improve taskflow type hints with ParamSpec #25173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
taskflow-xcom-arg-typehint
branch
from
972bf54 to
be0aa11
Compare
This is made available with our latest Mypy update. ParamSpec allows us to more accurately type a decorated task to return an XComArg (while still being correctly typed to accept the same arguments as the decorated function). This allows us to provide autocompletion for XComArg operations, such as map() and zip() introduced in AIP-42.
uranusjr
force-pushed
the
taskflow-xcom-arg-typehint
branch
from
be0aa11 to
dcfa461
Compare
ashb
approved these changes
Jul 26, 2022
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
One question. LGTM otherwise if that's not possible
| self, | ||
| *, | ||
| operation: Literal[available_operations], | ||
| operation: Literal['insert', 'update', 'upsert', 'delete', 'hard_delete'], |
Member
There was a problem hiding this comment.
Is it not possible to do
Suggested change
| operation: Literal['insert', 'update', 'upsert', 'delete', 'hard_delete'], | |
| operation: Literal[*available_operations], |
Member
Author
There was a problem hiding this comment.
Python syntactically does not allow using * in brackets. The previous Literal[available_operations] is valid Python but PEP 586 considered this out of scope.
This was referenced Aug 10, 2022
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs #25085 to be merged first. Only the last commit is relevant.Submitted for CI now.This should be ready. I needed to fix a few more (valid although unrelated) typing issues since Mypy started to flag them.
The main thing here is to replace the
Functiontype var withCallable[FParams, FReturn]so we can do polymorphism againstFParamswithout being tied toFReturn.