Implement map() semantic #25085
Merged
Implement map() semantic #25085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
aip-42-xcom-arg-map
branch
2 times, most recently
from
291baa5 to
26982ab
Compare
uranusjr
requested review from
XD-DENG,
ashb,
kaxil,
mik-laj and
potiuk
as code owners
This was referenced Jul 20, 2022
Member
|
I don't know too much on the details to have useful review, but if you need my review @uranusjr I can dig a bit deeper if other's won't chime in. |
Member
Author
|
Feel free! This one on its own shouldn’t need too much context to understand. |
jedcunningham
approved these changes
Jul 21, 2022
After implementing map(), the upstream of expand_kwargs() does not necessarily need to push a list of dicts, but a sequence of anything (and can rely on map() to convert elements to dicts). So we need to relax the restriction. If the map() function returns a non-dict, unmapping would fail anyway.
Some extra mechanism is added so we can continue to use XComArg like we do right now, but also prevent TransformedXComArg from needing to inherit a lot of the old XComArg nonsense like __str__ and __getitem__.
uranusjr
force-pushed
the
aip-42-xcom-arg-map
branch
from
26982ab to
28a06e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by adding a variant to the XComArg mechanism so we can hook extra logic into
resolve()at runtime.Some extra mechanism is added so we can continue to use XComArg like we do right now, but also prevent TransformedXComArg from needing to inherit a lot of the old XComArg nonsense like
__str__and__getitem__.Some validation is removed from the upstream that pushed the XCom, because with
map()we can no longer be sure the XCom is “wrong” when the upstream finishes (we can only know in the downstream, after transform functions are applied).