Allowing task_group Sensor in ExternalTaskSensor #24902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pateash
changed the title
Contributor
Author
cases
|
pateash
force-pushed
the
airflow-14563
branch
2 times, most recently
from
1425c95 to
eb29793
Compare
uranusjr
reviewed
Jul 18, 2022
Contributor
Author
|
Hi @eladkal, could you please take a look into this PR. |
Member
|
Since we are already allowing multiple task IDs, I wonder if we should just go directly with |
Contributor
Author
|
@uranusjr, we already allow multiple taskIds which I personally don't think a good idea, because it is not very transparent. Although For TaskGroup, I think if someone want to depend on multiple of them, they must create different task sensors. |
eladkal
reviewed
Aug 3, 2022
eladkal
reviewed
Aug 15, 2022
uranusjr
reviewed
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #14563
related: #14640
Add meaningful description above
Hi All,
This PR proposes to allow users to provide external_task_group_id in ExternalTaskSensor to make tasks on a DAG wait for another task_group on a different DAG for a specific execution_date.
we can also provide options to set if the Task on a remote DAG succeeded or failed via allowed_states and failed_states parameters.