TriggerDagRunOperator.operator_extra_links is attr #24676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Jun 27, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
There's absolutely no reason this needs to be a property. And it cannot be since we need to access this at the class level.
uranusjr
force-pushed
the
trigger-dag-run-operator-extra-links-attribute
branch
from
88769a8 to
759b6d1
Compare
ephraimbuddy
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jul 11, 2022
There's absolutely no reason this needs to be a property. And it cannot be since we need to access this at the class level. (cherry picked from commit 8dcafdf)
This was referenced Jul 22, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 15, 2022
There's absolutely no reason this needs to be a property. And it cannot be since we need to access this at the class level. (cherry picked from commit 8dcafdf)
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's absolutely no reason this needs to be a property. And it cannot be since we need to access this at the class level.
Fix #24653.